Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(csharp): update cdk configs for new csharp CI builds #230

Merged
merged 1 commit into from
Jan 16, 2020
Merged

chore(csharp): update cdk configs for new csharp CI builds #230

merged 1 commit into from
Jan 16, 2020
+10 −3

Conversation

NGL321
Copy link
Contributor

@NGL321 NGL321 commented Jan 16, 2020

  • Added package-lambda script to capitalize-string
  • Added context to elasticbeanstalk-environment
  • Added DO_NOT_AUTOTEST to static-site (requires user credentials in code)
  • Added context to static-site

Fixes #228

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Jan 16, 2020
@NGL321 NGL321 self-assigned this Jan 16, 2020
shivlaks
shivlaks reviewed Jan 16, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the DO_NOT_AUTOTEST do?

@NGL321
Copy link
Contributor Author

NGL321 commented Jan 16, 2020

what does the DO_NOT_AUTOTEST do?

The file is checked for by the build scripts, and if it is found, the example is skipped

@NGL321 NGL321 merged commit 16bf831 into aws-samples:master Jan 16, 2020
@shivlaks
Copy link
Contributor

what does the DO_NOT_AUTOTEST do?

The file is checked for by the build scripts, and if it is found, the example is skipped

gotcha, it’d also be good if we started capturing why we did that for posterity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks left review comments

@skinny85 skinny85 skinny85 approved these changes

@SomayaB SomayaB Awaiting requested review from SomayaB

Assignees

@NGL321 NGL321

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include CSharp in test scripts
3 participants
@NGL321 @shivlaks @skinny85